feat(router-timelock): add get_op_count, get_ops_by_state, and empty description validation#168
Merged
Maki-Zeninn merged 2 commits intoMaki-Zeninn:mainfrom Mar 30, 2026
Conversation
- Add InvalidDescription = 17 error variant - Guard queue against empty description strings - Add test_queue_empty_description_fails and test_queue_nonempty_description_succeeds - All 37 tests pass
|
@Markadrian6399 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the gap where frontends had to iterate all ops client-side with no server-side filtering, and prevents ops from being queued without a description.
Changes
New functions
get_op_count— returns total ops ever queued (readsNextOpId)Validation
queuenow rejects empty descriptions with newInvalidDescription = 17error variantBug fix
get_pending_ops(missing turbofish on.get())Tests
6 new tests added, all 37 pass:
test_get_op_count_zero_initiallytest_get_op_count_increments_on_queuetest_get_ops_by_state_pending_onlytest_get_ops_by_state_alltest_queue_empty_description_failstest_queue_nonempty_description_succeedscloses #158