Open
Conversation
Member
|
@rec - Read the README! https://github.com/ManiacalLabs/SimPixel/blob/master/README.md |
Collaborator
|
Sounds good to me. 2 seconds is reasonable for a remote server, but not for SimPixel which is always local. |
Member
|
The WebSocket connection is always local. SimPixel.io just loads the
"software" from a remote system, then connects local.
…On Mon, Aug 6, 2018 at 10:35 AM Michael Clayton ***@***.***> wrote:
Sounds good to me. 2 seconds is reasonable for a remote server, but not
for SimPixel which is always local.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6a6oZAiEHBZRIgZ5OdfWoCr4Es5DPcks5uOFQ3gaJpZM4VwUT2>
.
|
Contributor
Author
|
Well, that "worked" but I still can't really get it to reconnect at all well, either with my settings or the default settings. This is unfortunately an issue for the documentation. I don't want to tell people to have to restart that page each time... (https://github.com/rec/BiblioPixel/commits/docs is current progress. Ignore the build failures, they're some bullshit Travis thing I can't figure out.) Here are some different ways to reproduce this:
Another:
Another
But this works:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, when you restart the program it's extremely sluggish to reconnect, even if there's almost no pause between stopping one instance of bp and starting the next.
From the code, it looks as if the minimum possible delay is three seconds. This change reduces that to 300ms.
I don't really see any great downside to these tighter bounds. If your server can't respond to a simple "hello" in 200ms, even with unlimited retries, it's never going to be able to sustain any actual frame rate. And the cost of attempting to reconnect and fail is extremely small.
How can I run this locally to test it?