Skip to content

feat: implement serde for all the containers#60

Draft
aminya wants to merge 14 commits intoManishearth:masterfrom
aminya:serde
Draft

feat: implement serde for all the containers#60
aminya wants to merge 14 commits intoManishearth:masterfrom
aminya:serde

Conversation

@aminya
Copy link
Copy Markdown
Contributor

@aminya aminya commented Aug 10, 2023

No description provided.

@Manishearth
Copy link
Copy Markdown
Owner

I'm going to block this on figuring out the exact solution for #48 since that may change a bunch of the relevant internals here and I really don't want to complicate that situation more.

@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Aug 10, 2023

I can revert those affected by #48 until this is fixed
#48 (comment)

@Manishearth
Copy link
Copy Markdown
Owner

Manishearth commented Aug 10, 2023

That's going to be most of the important ones, and plus the changes I do there may also affect other types like the BTreeMaps. I don't think it's worth landing this PR with those things removed.

@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Sep 23, 2023

I actually prefer if you merge #62 before this PR as it allows me to test serialization/deserialization back-to-back via assert_eq

@aminya aminya marked this pull request as draft September 23, 2023 09:21
@aminya aminya marked this pull request as ready for review October 25, 2023 04:38
@aminya aminya marked this pull request as draft November 19, 2023 06:19
@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Nov 19, 2023

Waiting for #72 so that I can add the tests for all implementations.

@Caligari
Copy link
Copy Markdown

Is this going to be merged at some point? It seems like useful functionality.

@Manishearth
Copy link
Copy Markdown
Owner

I don't really have time to work on #48 right now and I still think that's a prerequisite here.

@Manishearth
Copy link
Copy Markdown
Owner

A PR that doesn't touch the hash-based ones would be mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants