feat: implement sync variants of FrozenIndexMap, FrozenIndexSet#67
Open
huitseeker wants to merge 5 commits intoManishearth:masterfrom
Open
feat: implement sync variants of FrozenIndexMap, FrozenIndexSet#67huitseeker wants to merge 5 commits intoManishearth:masterfrom
huitseeker wants to merge 5 commits intoManishearth:masterfrom
Conversation
huitseeker
force-pushed
the
sync_frozen
branch
2 times, most recently
from
17dc3e5 to
4944e9b
Compare
huitseeker
force-pushed
the
sync_frozen
branch
from
4944e9b to
166078c
Compare
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 14, 2023
- Updated Elsa dependency branch from `sync_index_map` to `sync_frozen`. - the elsa import now matches Manishearth/elsa#67 and thus a more recent version of elsa. - Corrected the import statement in `hash.rs`. - Modified import paths for `FrozenIndexSet` in the `store.rs` and `lem/store.rs` files.
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 14, 2023
- Updated Elsa dependency branch from `sync_index_map` to `sync_frozen`. - the elsa import now matches Manishearth/elsa#67 and thus a more recent version of elsa. - Corrected the import statement in `hash.rs`. - Modified import paths for `FrozenIndexSet` in the `store.rs` and `lem/store.rs` files.
github-merge-queue bot
pushed a commit
to lurk-lab/lurk-beta
that referenced
this pull request
Nov 15, 2023
* chore: Update Elsa dependency and correct import paths - Updated Elsa dependency branch from `sync_index_map` to `sync_frozen`. - the elsa import now matches Manishearth/elsa#67 and thus a more recent version of elsa. - Corrected the import statement in `hash.rs`. - Modified import paths for `FrozenIndexSet` in the `store.rs` and `lem/store.rs` files. * chore: update criterion dependency
- Renamed and relocated `sync_index_set.rs` and `sync_index_map.rs` files into a new `sync` directory for better file structuring. - Enabled custom `Debug` implementations for sync variants of `FrozenIndexSet` and `FrozenIndexMap`. - Introduced feature-gated support for `indexmap` within `sync` with `index_map` and `index_set` modules.
huitseeker
force-pushed
the
sync_frozen
branch
from
166078c to
4f553a5
Compare
- Introduced "shuttle" feature configurations for `RwLock` in `index_set.rs` and `index_map.rs`, allowing for switch between `std::sync::RwLock` and `shuttle::sync::RwLock` based on testing conditions. - Added tests under "shuttle" feature to validate various functionalities such as idempotent and incremental insertions, multiple call interactions and retrieval by index in both `index_set.rs` and `index_map.rs`. - Added the optional dependency "shuttle" version "0.6.1" to `Cargo.toml` and included it in the list of features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10 added
FrozenIndexMap,FrozenIndexSetunder a feature, but not sync variants thereof.This adds those sync variants.