-
Notifications
You must be signed in to change notification settings - Fork 23
Add Readiness and Liveness Probes to All Deployments #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Readiness and Liveness Probes to All Deployments #49
Conversation
- workflows are added - minikube tunnling are added - metric-server is added - some devops optimisation
- Auto comment for PR's
- k8s files are combined for each service - auto comment workflow updated
Hi @reshma2004 Thanks for creating a PR for your Issue!
|
Manoj-14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @reshma2004. Please review the changes for login-service.yaml file. Other then that every thig loogs good for me.
|
I changed the version back to v1.2.0 |
c05db60 to
637ab5a
Compare
637ab5a to
f0e9299
Compare
|
I had some difficulty pushing files. Yes, I changed the version back to v1.2.0. |
Manoj-14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @reshma2004 for resolving the issue, will merge it to stage then will merge to master.
|
Hi Manoj,
Thanks for merging the PR. ! I'm glad I could contribute.Looking
forward to contributing.
Thanks
Reshma
…On Sun, Jan 11, 2026 at 7:05 AM Manoj M ***@***.***> wrote:
Closed #49 <#49>.
—
Reply to this email directly, view it on GitHub
<#49 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGWF7RSKJEOMYKHB7TXKFD4GI37BAVCNFSM6AAAAACRJK7JQWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRHE3DSOJSHEZDMNI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
📄
Pull Request Template📌 Description
Please provide a clear and concise description of the changes in this PR.
What does this PR do?
Why is this change needed?
🔗 Related Issue
Link the issue this PR addresses (if applicable):
Fixes #25
🛠️ Type of Change
Please mark the relevant option:
🧪 How Was This Tested?
Describe how you verified your changes:
📸 Screenshots (if applicable)
Add screenshots or logs if this change affects UI or behavior.
✅ Checklist
Please confirm the following:
📝 Additional Notes
Anything else the maintainers should know?
login-service.yaml had missing labels and different container image(v1.2.0). Rest other service files had container image v1.1.0 So I modified the container image and added missing labels. in login-service.yaml. However container images does not match with readme.md and setup.md. I also added rolling update.