fix(level-23): remove service name from validation#29
Open
rhotertj wants to merge 1 commit intoManoj-engineer:mainfrom
Open
fix(level-23): remove service name from validation#29rhotertj wants to merge 1 commit intoManoj-engineer:mainfrom
rhotertj wants to merge 1 commit intoManoj-engineer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📝 Description
Level 23 is about fixing the connection between the database and the client by correcting a hostname mismatch.
The solution is to either rename the service to match the client's request or to change the pods command args to match the service name.
The current validation script does not allow the service name to be changed because it is hard-coded as an expected value. Although the logs report a successful connection when the service name is changed, the mission fails.
Therefore, I removed the service name from the log validation.
🎯 Type of Change
🔗 Related Issue
Fixes #(issue number)
📍 Affected Levels/Areas
✅ Testing Checklist
🧪 How to Test
📸 Screenshots/Logs (if applicable)
📚 Documentation Updates
✨ Additional Notes
🤔 Questions for Reviewers
Reviewer Checklist