Skip to content

fix(level-23): remove service name from validation#29

Open
rhotertj wants to merge 1 commit intoManoj-engineer:mainfrom
rhotertj:fix/level-23-relax-validation
Open

fix(level-23): remove service name from validation#29
rhotertj wants to merge 1 commit intoManoj-engineer:mainfrom
rhotertj:fix/level-23-relax-validation

Conversation

@rhotertj
Copy link
Copy Markdown

Pull Request

📝 Description

Level 23 is about fixing the connection between the database and the client by correcting a hostname mismatch.
The solution is to either rename the service to match the client's request or to change the pods command args to match the service name.

The current validation script does not allow the service name to be changed because it is hard-coded as an expected value. Although the logs report a successful connection when the service name is changed, the mission fails.
Therefore, I removed the service name from the log validation.

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎮 New level/challenge
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🎨 UI/UX improvement

🔗 Related Issue

Fixes #(issue number)

📍 Affected Levels/Areas

  • World 1 - Basics
  • World 2 - Deployments
  • World 3 - Networking
  • World 4 - Storage
  • World 5 - Security
  • Game Engine
  • Documentation
  • Other: ___________

✅ Testing Checklist

  • I have tested this locally
  • I have run the affected level(s) end-to-end
  • Validation scripts pass correctly
  • Hints are clear and helpful
  • Solution works as intended
  • Debrief explains the concept well
  • No breaking changes to other levels
  • Code follows the project style

🧪 How to Test

📸 Screenshots/Logs (if applicable)

📚 Documentation Updates

  • README.md updated (if needed)
  • Level documentation updated (if applicable)
  • Comments added to complex code
  • CHANGELOG.md updated (if significant change)

✨ Additional Notes

🤔 Questions for Reviewers


Reviewer Checklist

  • Code quality is acceptable
  • Changes align with K8sQuest's learning objectives
  • No security concerns
  • Documentation is adequate
  • Tested locally and works as described

@rhotertj rhotertj changed the title fix: remove service name from validation fix(level-23): remove service name from validation Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant