Skip to content

Conversation

@zqhxuyuan
Copy link
Contributor


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

const address = {
bab: "YOUR BAB ADDRESS"
}
const allowlistTx = await api.tx.mantaSbt.allowlistEvmAccount(address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include sudo calls to set account and mint time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do in future PR


```json
{
Available: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why highlighted red, maybe it should be "Available": 1

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
2. reserve asest id before mint zkSBT.

```typescript
const reserverTx = await api.tx.mantaSbt.reserveSbt();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const reserverTx = await api.tx.mantaSbt.reserveSbt();
const reserveTx = await api.tx.mantaSbt.reserveSbt();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants