fix: update metadata with same product name (MAPCO-8593)

.github/workflows/pull_request.yaml

@@ -4,7 +4,7 @@ on: [pull_request]
 
 jobs:
   pull_request:
-    uses: MapColonies/shared-workflows/.github/workflows/pull_request.yaml@v5
+    uses: MapColonies/shared-workflows/.github/workflows/pull_request.yaml@v4
     secrets: inherit
     with:
       openApiFilePath: './bundledApi.yaml'

src/validator/validationManager.ts

@@ -199,7 +199,8 @@ export class ValidationManager {
 
     if (payload.productName != undefined) {
       const records = await this.catalog.findRecords({ productName: payload.productName });
-      if (records.length > 0) {
+      const differentRecordsWithSameNameExists = records.some((recordWithSameName) => recordWithSameName.id !== identifier);
+      if (differentRecordsWithSameNameExists) {
         refReason.outFailedReason = ERROR_METADATA_PRODUCT_NAME_UNIQUE!;
         return false;
       }

tests/integration/metadata/metadataController.spec.ts

@@ -71,6 +71,25 @@ describe('MetadataController', function () {
         expect(response).toSatisfyApiSpec();
       });
 
+      it(`Should return 200 status code if record product name is my name (unique)`, async function () {
+        const identifier = faker.string.uuid();
+        const payload = createUpdatePayload();
+        const expected = createRecord();
+        const record = createRecord();
+        record.id = identifier;
+        const linkUrl = extractLink(record.links);
+        await s3Helper.createFile(linkUrl, true);
+        mockAxios.get.mockResolvedValueOnce({ status: StatusCodes.OK, data: record });
+        mockAxios.get.mockResolvedValueOnce({ data: [{ value: payload.classification }] as ILookupOption[] });
+        mockAxios.post.mockResolvedValueOnce({ status: StatusCodes.OK, data: [record] });
+        mockAxios.patch.mockResolvedValueOnce({ status: StatusCodes.OK, data: expected });
+
+        const response = await requestSender.updateMetadata(identifier, payload);
+
+        expect(response.status).toBe(StatusCodes.OK);
+        expect(response).toSatisfyApiSpec();
+      });
+
       it(`Should return 200 status code and metadata if payload is valid and footprint is 3D and pass footprint 2D to catalog`, async function () {
         const identifier = faker.string.uuid();
         const payload = createUpdatePayload('Sphere');