Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates linting workflows by integrating lint jobs into the main CI workflow and removing the separate lint workflow file.
- Adds a new
lintjob to the main CI workflow with helm-lint and eslint steps - Removes the commented-out lint workflow file that was previously disabled
- Adds necessary permissions for the workflow to read repository contents and pull requests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/Main.yaml | Adds lint job with helm-lint and eslint actions, plus required permissions |
| .github/workflows/Lint.yml | Removes the entire commented-out lint workflow file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@alebinson You can choose if you want to remove |
alebinson
requested changes
Sep 28, 2025
Collaborator
There was a problem hiding this comment.
Too much prettier errors
think that
prettier_dir: ${{ env.CODE_DIR }}
cause the issue.
Probably / is missing (e.g. prettier_dir: ${{ env.CODE_DIR }}/)
Directories like mocks, mocks-data should be excluded
In general think there is something with prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.