Skip to content

ci: run lints during PR#671

Open
shimoncohen wants to merge 7 commits intomasterfrom
setup-lint-in-workflows
Open

ci: run lints during PR#671
shimoncohen wants to merge 7 commits intomasterfrom
setup-lint-in-workflows

Conversation

@shimoncohen
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates linting workflows by integrating lint jobs into the main CI workflow and removing the separate lint workflow file.

  • Adds a new lint job to the main CI workflow with helm-lint and eslint steps
  • Removes the commented-out lint workflow file that was previously disabled
  • Adds necessary permissions for the workflow to read repository contents and pull requests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/Main.yaml Adds lint job with helm-lint and eslint actions, plus required permissions
.github/workflows/Lint.yml Removes the entire commented-out lint workflow file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shimoncohen
Copy link
Contributor Author

@alebinson You can choose if you want to remove prettier check.

Copy link
Collaborator

@alebinson alebinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much prettier errors
think that
prettier_dir: ${{ env.CODE_DIR }}
cause the issue.
Probably / is missing (e.g. prettier_dir: ${{ env.CODE_DIR }}/)
Directories like mocks, mocks-data should be excluded
In general think there is something with prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants