Skip to content

fix: no unnecesary form #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alebinson merged 1 commit into from
Feb 26, 2026
+12 −4
Merged

fix: no unnecesary form #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/Wizard/MetadataConfirm/MetadataConfirm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const MetadataConfirm: React.FC<WizardStepProps> = ({
</Typography>
))}
</Box>
<form className="form">
<Box className="form">
<Box className="formGroup">
<label htmlFor="password">
<FormattedMessage id="form.password.label" />
Expand All @@ -128,13 +128,19 @@ export const MetadataConfirm: React.FC<WizardStepProps> = ({
name="password"
value={formData.password}
onChange={handleChange}
onKeyDown={(e: React.KeyboardEvent<HTMLInputElement>): void => {
const SUBMIT_KEY = 'Enter';
if (formData.password && e.key === SUBMIT_KEY) {
setShouldSubmit?.(true);
}
}}
required
className="textField"
placeholder={intl.formatMessage({ id: 'form.password.placeholder' })}
autoComplete="off"
/>
</Box>
</form>
</Box>
</Box>
</Box>
);
Expand Down
4 changes: 2 additions & 2 deletions src/components/Wizard/MetadataForm/MetadataForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const MetadataForm: React.FC<WizardStepProps> = ({
id={`${selectedItem?.isApproved ? 'form.message.reject' : 'form.message.approve'}`}
/>
</Box>
<form className="form">
<Box className="form">
<Box className="formGroup">
<label htmlFor="approver">
<FormattedMessage id="form.approver.label" />
Expand Down Expand Up @@ -88,7 +88,7 @@ export const MetadataForm: React.FC<WizardStepProps> = ({
placeholder={intl.formatMessage({ id: 'form.remarks.placeholder' })}
/>
</Box>
</form>
</Box>
</Box>
</Box>
);
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

"err.code.INVALID_CREDENTIALS": "Invalid username or password",
"err.code.INVALID_RECORD_NAME": "Model not found",
"err.code.INVALID_RECORD_NAME_ANOTHER_SITE": "Model not found in all site(s)",

"auth.login.btn": "Login",
"auth.logout.btn": "Logout",
Expand Down
1 change: 1 addition & 0 deletions src/i18n/locales/he.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

"err.code.INVALID_CREDENTIALS": "שם משתמש או סיסמה לא חוקיים",
"err.code.INVALID_RECORD_NAME": "מודל לא קיים",
"err.code.INVALID_RECORD_NAME_ANOTHER_SITE": "מודל לא קיים בכל האתרים",

"auth.login.btn": "התחבר",
"auth.logout.btn": "התנתק",
Expand Down
Loading