Skip to content

feat: get response also when no result was chosen (MAPCO-5804)#7

Merged
NatalieShaked merged 107 commits intomasterfrom
feat/no-chosen-feedback
Feb 12, 2025
Merged

feat: get response also when no result was chosen (MAPCO-5804)#7
NatalieShaked merged 107 commits intomasterfrom
feat/no-chosen-feedback

Conversation

@NatalieShaked
Copy link
Collaborator

@NatalieShaked NatalieShaked commented Jan 16, 2025

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Description:

  • Fixed workflow build-and-push.
  • Created 2 Redis clients and a Redis PubSub. First Redis client for the response from geocoding, Second Redis client as a TTL for the geocoding response. Redis PubSub to listen to when there is a new request was, and to when the request expired.
  • Added Integration tests.

@NatalieShaked NatalieShaked self-assigned this Jan 16, 2025
@NivGreenstein NivGreenstein changed the title Feat: get response also when no result was chosen (MAPCO-5804) feat: get response also when no result was chosen (MAPCO-5804) Jan 16, 2025
@NatalieShaked NatalieShaked marked this pull request as ready for review January 21, 2025 14:07
@NivGreenstein
Copy link
Contributor

Please add some documentation in README.md

@NatalieShaked NatalieShaked merged commit 844ebc9 into master Feb 12, 2025
7 checks passed
@NatalieShaked NatalieShaked deleted the feat/no-chosen-feedback branch February 12, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants