fix: remove redis logical db (MAPCO-6821)#9
Merged
NatalieShaked merged 4 commits intomasterfrom Feb 27, 2025
Merged
Conversation
NivGreenstein
approved these changes
Feb 26, 2025
Comment on lines
59
to
61
| "database": { | ||
| "__name": "REDIS_DATABASE", | ||
| "__format": "number" |
Contributor
There was a problem hiding this comment.
We use Redis Enterprise. Is there any use for REDIS_DATABASE if there are no logical databases anymore.
config/default.json
Outdated
| "geocodingIndex": 0, | ||
| "ttlIndex": 1 | ||
| }, | ||
| "database": 0, |
src/redis/subscribe.ts
Outdated
| import { NotFoundError } from '../common/errors'; | ||
| import { RedisClient } from '../redis/index'; | ||
|
|
||
| const REDIS_PREFIX = 'ttl_'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further information:
Our previous logic used Redis logical databases, but when we tried it with Redis Enterprise, it did not work, since Redis Enterprise does not support logical databases within an existing database.
So instead of logical databases, we used prefixes.