feat: added abort api endpoint (MAPCO-8328)#59
Merged
CL-SHLOMIKONCHA merged 20 commits intoalphafrom Feb 8, 2026
Merged
Conversation
Contributor
roicohen326
commented
Jan 18, 2026
roicohen326
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✔ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✖ |
CL-SHLOMIKONCHA
requested changes
Jan 19, 2026
Contributor
|
Attach the issue from jira (MAPCO) to PR title |
roicohen326
changed the title
Contributor
Author
fixed |
CL-SHLOMIKONCHA
requested changes
Jan 20, 2026
CL-SHLOMIKONCHA
requested changes
Jan 21, 2026
* test: add unit tests for abort deployment functionality * fix: remove unused isJobAbortableSpy * fix: return empty array from get task stub * chore: removed unnecessary tests and rearranged in it each fromat * chore: fixed tests description * chore: fixed untracked jobs unit tests * chore: fixed actions bad pattern * chore: removed unnecessary BadRequestError * chore: merge invalid status tests and use mock generator * chore: fixed bad jobmanager tests patterns * test: add job manager wrapper integration tests * chore: removed unnecessary integration tests * chore: fixed lint problems * test: fixed wrong http status code * test: add bad and sad abort integration tests * test: fixed infocontroller unit tests * chore: fix uncovered vlaidation unit tests * chore: removed unnecessary controllers unit testing due to prototype instance of conflict * chore: refactor abort mocks and extract abort statuses as const * test: adjust generateMockJob + abort expectations * test: removed unnecessary as const definition * style: fix lint errors * style: removed unused import * chore: fix eslint warnings --------- Co-authored-by: shlomiko <shlomiko@rafael.co.il>
vitaligi
reviewed
Feb 5, 2026
openapi3.yaml
Outdated
Contributor
There was a problem hiding this comment.
please fix this description to Internal Server Error
in other places where 500 error is described fix the casing to as above
tnx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.