feat(auto-merge): create auto merge action MAPCO-9003#104
feat(auto-merge): create auto merge action MAPCO-9003#104michalby24 merged 27 commits intomasterfrom
Conversation
…label check logic
netanelC
left a comment
There was a problem hiding this comment.
Always look for ready-to-use actions before you implement one. There is already an open-source action for that 👀
I looked into switching to pascalgn/automerge-action as suggested. Per its own documentation: “When the pull request is ready, it will automatically be merged. The action will only wait for status checks that are marked as required in the branch protection rules.” In our current setup, this isn’t enforceable because branch rulesets are not applied to private repositories on our plan:
As a result, the action can merge PRs before CI finishes, which we already observed. My custom action explicitly waits for all PR checks to complete successfully inside the action itself, so it behaves correctly regardless of branch protection or plan limitations. |
So you can separate to 2 steps: validating and merging. No need to implement the merge action (or the validatation stage in case this action does the job) |
@michalby24 @netanelC this action is being maintained anymore, the last commit was over 1 year ago, i don't feel comfortable using such an old open source code |
Too bad.. It seems like a good action |
|
should add auto-merge action also to .release-please-manifest.json |
ronenkapelian
left a comment
There was a problem hiding this comment.
one comment about the release-please-manifest,
The test-auto-merge validating the "easy" flow when its not auto-merged, what about the intersting flow, when its true? any way to test it?






This pull request introduces a new GitHub Action for automatically merging pull requests that have the
auto-mergelabel, and sets up workflow and release configuration for it. The action checks for the label, waits for required checks to pass, and merges the PR if conditions are met.example: https://github.com/MapColonies/test-site/pull/60/ and here