fix(build-and-push-helm): fix action#76
Merged
michalby24 merged 22 commits intomasterfrom Jul 3, 2025
Merged
Conversation
added 8 commits
July 2, 2025 10:39
netanelC
requested changes
Jul 2, 2025
Contributor
netanelC
left a comment
netanelC
left a comment
There was a problem hiding this comment.
Why did you remove the chart name and the tag? They are necessary for update-artifacts-file action
Contributor
Author
I have restored it |
netanelC
requested changes
Jul 2, 2025
Contributor
netanelC
left a comment
netanelC
left a comment
There was a problem hiding this comment.
You are still changing the workflow instead of fixing it. Why do you need the package_file? It will require the teams to add it too
netanelC
requested changes
Jul 3, 2025
alex131290
reviewed
Jul 3, 2025
alex131290
reviewed
Jul 3, 2025
Contributor
|
@michalby24 can you please provide a working workflow execution which is using this action? |
netanelC
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes the Helm chart publishing action by reliably capturing the generated chart filename using the output of helm package
workflow runs can be seen here: https://github.com/MapColonies/actions/actions/workflows/test-build-and-push-helm.yaml