Skip to content

fix: remove unnecessary checkout #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
netanelC merged 1 commit into from
Sep 25, 2025
Merged

fix: remove unnecessary checkout #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions actions/update-artifacts-file/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ runs:
ARTIFACT_TAG: ${{ inputs.artifact_tag }}
TYPE: ${{ inputs.type }}
REGISTRY: ${{ inputs.registry }}
TARGET_DIR: $TARGET_PATH
TARGET_PATH: $TARGET_PATH

- name: Commit and push changes
run: ${{ github.action_path }}/commit_changes.sh
Expand All @@ -64,7 +64,7 @@ runs:
TYPE: ${{ inputs.type }}
GITHUB_TOKEN: ${{ inputs.github_token }}
TARGET_REPO: ${{ inputs.target_repo }}
TARGET_DIR: $TARGET_PATH
TARGET_PATH: $TARGET_PATH
TARGET_BRANCH: ${{ inputs.target_branch }}

- name: Clean up target repo folder
Expand Down
4 changes: 1 addition & 3 deletions actions/update-artifacts-file/commit_changes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
#!/bin/bash
cd "$TARGET_DIR"
cd "$TARGET_PATH"

git config user.name "mapcolonies[bot]"
git config user.email "devops[bot]@mapcolonies.com"

git checkout "$TARGET_BRANCH"

git add "$DOMAIN/artifacts.json"
git commit -m "chore: update artifacts.json for $DOMAIN" -m "with $TYPE artifact: $ARTIFACT_NAME:$ARTIFACT_TAG" || echo "Nothing to commit"

Expand Down
2 changes: 1 addition & 1 deletion actions/update-artifacts-file/modify_artifacts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
ARTIFACTS_PATH="$TARGET_DIR/$DOMAIN/artifacts.json"
ARTIFACTS_PATH="$TARGET_PATH/$DOMAIN/artifacts.json"

# Make sure the directory exists
mkdir -p "$(dirname "$ARTIFACTS_PATH")"
Expand Down