Add DB_CHARSET Configuration Support #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced DB_CHARSET environment variable with a default value of "utf8mb4" - Updated connection pool logging to include charset information - Enhanced MariaDBServer initialization to utilize the charset setting
- Removed default value for DB_CHARSET in configuration - Updated connection pool initialization to conditionally include charset in parameters - Enhanced logging to reflect whether charset is set or not
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces configurable database character set support for MariaDB connections,
allowing users to specify the character encoding used for their database connections
through an environment variable.
Changes
optional
Implementation Details
that can be set to specify the database connection character set
- Conditionally include charset in connection parameters only when specified
- Enhanced logging to clearly indicate whether a charset is configured
Benefits
encodings
Testing
The changes have been tested with:
Breaking Changes
None - this is a backward-compatible enhancement.