EventBus instead of AsyncTasks#18
Open
tajchert wants to merge 1 commit intoMariuxtheone:masterfrom
Open
Conversation
Contributor
|
I like the idea of using an eventbus. I would have rather used Otto I think, but I've nothing against this one. All in all, I think this lib should be built on a bus and still offer callbacks for easy use. Also this is a big change. This could be a whole new library ^^ About the pull-request in itself, the code is clear since very light weighted. There is still a little bit of work required to polish the readme before merging. |
|
+1, this is an awesome idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced AsyncTaks with EventBus ( 🚌 ) that allows to achieve same results with 30% less code in library and 30% less code in the sample, and (for me at least) it is way more clear/easy to work.
I have also updated README file to describe EventBus - it is not ready to be merged (it was done for fork), so README file for sure needs to be changed, or use branch "bus" which does include old README file.
Please lets use that thread to discuss disadvantages of such solution, as I may be missing something. Also I do understand the point that such change is radical and will make all code not supporting newer versions of Teleport without some change.