Add controller info endpoint model (Related issue: #75)#78
Open
rubempoli wants to merge 1 commit intoMarkGodwin:masterfrom
Open
Add controller info endpoint model (Related issue: #75)#78rubempoli wants to merge 1 commit intoMarkGodwin:masterfrom
rubempoli wants to merge 1 commit intoMarkGodwin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #75
This PR exposes the diagnostic information returned by the Omada Controller
/api/infoendpoint asOmadaControllerInfo.The library already uses
/api/infointernally to retrievecontrollerVerandomadacId. This change keeps the existing_get_controller_info()behavior intact and adds a publicget_controller_info()method exposing the remaining fields returned by the API.Fields exposed:
This is useful for consumers such as Home Assistant to represent the Omada Controller itself as a diagnostic entity.
The existing hardware controller firmware/update helpers are not changed.
Validated against Omada Software Controller 6.2.10.15.
Local validation:
git diff --checkpython -m compileall srcget_controller_info()against Omada Software Controller 6.2.10.15Home Assistant behavior validated locally:
/api/inforesponds withconfigured=true/api/infounreachable