MB-88: Define security checks to perform on projects #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xredo
requested changes
Nov 18, 2025
Member
xredo
left a comment
xredo
left a comment
There was a problem hiding this comment.
I have left some comments to provide more information and context to some of the topics covered in the changes.
The rest is great!
|
|
||
| [Snyk](https://snyk.io/) is one such tool. It is cross-platform and allows detecting vulnerabilities in several language runtimes, in Docker images, Infrastructure-as-Code definitions, and Open Source dependencies. | ||
|
|
||
| We will also check the dependency scanner built in GitHub or GitLab. |
Member
There was a problem hiding this comment.
As we don't use Gitlab, we can leave just Github and offer more details. Those are the official instructions to enable dependabot in Github projects:
https://docs.github.com/en/code-security/getting-started/dependabot-quickstart-guide
Comment on lines
+41
to
+45
| - Tools or lint rules should flag: | ||
| - Any usage of dangerouslySetInnerHTML without sanitization | ||
| - Dynamic calls to child_process | ||
| - Dynamic require() using untrusted data | ||
| - Unvalidated users or session access |
Member
There was a problem hiding this comment.
Currently we are using ESLint for our projects. So we can mention specific rules that we can use to enforce this:
- Any usage of dangerouslySetInnerHTML without sanitization: eslint-plugin-react has react/no-danger
- Dynamic calls to child_process: eslint-plugin-security has security/detect-child-process
- Dynamic require(): eslint-plugin-import: import/no-dynamic-require
- Unvalidated users or session access: I don't know any ESLint rule for this. I don't iknow if we can force this.
Comment on lines
+50
to
+52
| - _docker scan_ or platform-provided scanners | ||
| - Snyk container scanning | ||
| - Make sure the containers are built on top of OS images that are still supported and receiving security upgrades. |
Comment on lines
+120
to
+123
| ## Logging, Monitoring & Alerts | ||
|
|
||
| Check that: | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Closes # .
List of Changes
Checklist