Merged
Conversation
kellenwiltshire
commented
Mar 21, 2026
Comment on lines
+8
to
+22
| function isPublicFile(pathname: string): boolean { | ||
| // Static files in public folder | ||
| const staticFileExtensions = | ||
| /\.(png|jpg|jpeg|svg|ico|webp|webmanifest|json)$/i | ||
| if (staticFileExtensions.test(pathname)) return true | ||
|
|
||
| // Specific known public files | ||
| if (pathname === '/favicon.ico') return true | ||
| if (pathname.startsWith('/apple-icon')) return true | ||
| if (pathname.startsWith('/web-app-manifest-')) return true | ||
| if (pathname.startsWith('/icon')) return true | ||
|
|
||
| return false | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
We don't want to redirect on public folder items
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MarshallAsch
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PWA support added. No push notifications added, not sure if needed/required at this stage.