fix: resolve mailgun email template type errors#99
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Marve10s
force-pushed
the
fix/mailgun-email-template-types
branch
from
44d5bd0 to
68ddf49
Compare
- Use MailgunMessageData type instead of Record<string, unknown> for message data objects - Fix validateEmail to use correct v10 API fields (result.result instead of result.is_valid, remove non-existent did_you_mean) - Include text field in initial message data to satisfy AtLeastOneKeyPresent constraint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Marve10s
force-pushed
the
fix/mailgun-email-template-types
branch
from
68ddf49 to
993de23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MailgunMessageDatatype instead ofRecord<string, unknown>for message data objects passed tomg.messages.create()validateEmailto use correct mailgun.js v10 API fields (result.resultinstead ofresult.is_valid, remove non-existentdid_you_mean)textfield in initial message data to satisfyAtLeastOneKeyPresenttype constraintTest plan
bun test --update-snapshots apps/cli/test/template-snapshots.test.ts— all 34 pass🤖 Generated with Claude Code