fix(env): revert Docker base to python:3.12 + sync stale 260->263 in CI#13
Merged
fix(env): revert Docker base to python:3.12 + sync stale 260->263 in CI#13
Conversation
Two related fixes shipped together: 1. Reverts the Dependabot-merged Docker base bump from python:3.14 to python:3.12-slim-bookworm. Reason: Step 5 architectural rule #3 ("what is tested locally = what runs in prod") was broken by the bump — CI test job pins PYTHON_VERSION="3.12" while the production Docker image was running 3.14. Tests would not have caught a future 3.14-only regression. Python 3.14 is brand-new (Oct 2025); conservative choice for a portfolio project is to track 3.12 in both surfaces until 3.14 is the enterprise norm. Aligns with the sibling portfolio projects which also pin 3.12. 2. Updates two stale "260-test suite" / "260 hermetic tests" comments in .github/workflows/ci.yml to "263" — the actual current count after the README-rewrite PR added 2 new section-heading tests. Same kind of stale-string we caught in the UI footer earlier. Risk removed: env divergence between CI and prod (the kind of bug that ships silently and only surfaces when a 3.14-specific issue appears, by which point CI confidence is already broken). Future: when the 3.14 Dependabot PR re-opens, close it with a comment explaining the env-pin policy until 3.14 is mainstream. Tests: 263 still passing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related fixes shipped together:
Reverts the Dependabot-merged Docker base bump from python:3.14 to python:3.12-slim-bookworm. Reason: Step 5 architectural rule chore(ci): bump actions/checkout from 4 to 6 #3 ("what is tested locally = what runs in prod") was broken by the bump — CI test job pins PYTHON_VERSION="3.12" while the production Docker image was running 3.14. Tests would not have caught a future 3.14-only regression. Python 3.14 is brand-new (Oct 2025); conservative choice for a portfolio project is to track 3.12 in both surfaces until 3.14 is the enterprise norm. Aligns with the sibling portfolio projects which also pin 3.12.
Updates two stale "260-test suite" / "260 hermetic tests" comments in .github/workflows/ci.yml to "263" — the actual current count after the README-rewrite PR added 2 new section-heading tests. Same kind of stale-string we caught in the UI footer earlier.
Risk removed: env divergence between CI and prod (the kind of bug that ships silently and only surfaces when a 3.14-specific issue appears, by which point CI confidence is already broken).
Future: when the 3.14 Dependabot PR re-opens, close it with a comment explaining the env-pin policy until 3.14 is mainstream.
Tests: 263 still passing locally.