Add support for displaying Spell Points in Tidy5e Sheet#11
Open
CeaneC wants to merge 3 commits intoMary-Usagi:masterfrom
Open
Add support for displaying Spell Points in Tidy5e Sheet#11CeaneC wants to merge 3 commits intoMary-Usagi:masterfrom
CeaneC wants to merge 3 commits intoMary-Usagi:masterfrom
Conversation
|
When trying to download through the module.json manifest url I get error: An unexpected error occurred when downloading file WILL BE AUTO REPLACED: Invalid URL Is there another way of downloading this update or is it meant to be merged into dev? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for displaying Spell Points as an attribute or a resource in Tidy5e Sheet
Attribute
Resource
Other code changes/justifications
TEMPLATESmodel to better support possible future additions of different sheetsinputelement for the maximum spell points value, and set it todisabledto stop people from editing it (it would get overridden when the sheet reloads anyway). Tidy5e's css is set up forinputelements, using aspanor something else that's static would require us adding new css which I'm trying to avoid for forwards-compatibilityKnown Issues
When displaying spell points as a resource, the resource is only visible if:
If not, the entire resource block disappears as the locked version of the sheet tidies up unused elements. The cleanup code is called in the
renderTidy5eSheethookhttps://github.com/sdenec/tidy5e-sheet/blob/99bf2912400eb860a99042e02e2adfd7f3c7cbb2/src/scripts/tidy5e-sheet.js#L548-L550
https://github.com/sdenec/tidy5e-sheet/blob/99bf2912400eb860a99042e02e2adfd7f3c7cbb2/src/scripts/tidy5e-sheet.js#L298-L304
which is called before
renderActorSheet5e. This could be fixed if we could append the spell points resource before/during therenderTidy5eSheethook.Closes #10