Vertical orientation slider needs to have minimum at the bottom#36
Open
rajataggarwal91 wants to merge 2 commits intoMasterMaps:masterfrom
rajataggarwal91:master
Open
Vertical orientation slider needs to have minimum at the bottom#36rajataggarwal91 wants to merge 2 commits intoMasterMaps:masterfrom rajataggarwal91:master
rajataggarwal91 wants to merge 2 commits intoMasterMaps:masterfrom
rajataggarwal91:master
Conversation
When orientation of slider was set to vertical, the minimum of axes started from top instead of bottom. Even then the values did not match the labels. The change is just an inversion of range. This has not been thoroughly tested, but it works fine for my application
Removed console.log in previous change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a wrong mapping of values in axes and the actual slider values. Plus the axes should have minimum at the bottom as it is more intuitive.
I used the following code in my application and was facing problems which was solved later using the committed code.
d3.select('#Vslider').call(d3.slider().value(30).orientation("vertical").axis(true).min(-40).max(60).step(1).on("slide", function(evt, value) {
console.log(value);
d3.select('#Temperature').text(value)
;
}));