Custom scale support and sizing based on rendered container width#38
Open
megankanne wants to merge 3 commits intoMasterMaps:masterfrom
Open
Custom scale support and sizing based on rendered container width#38megankanne wants to merge 3 commits intoMasterMaps:masterfrom
megankanne wants to merge 3 commits intoMasterMaps:masterfrom
Conversation
megankanne
commented
Aug 12, 2015
- Enables completely custom scales (eg. a polylinear scale) by only setting scale range if scale is not provided by user.
- Removes use of two scales ("scale" to map input value to slider width percentage and "axisScale" to map input value to slider pixel position). Replaces them with single scale mapping input value to slider pixel position and a function to translate that slider pixel position to a percentage of slider length.
- Removes requirement that container div has a css width style explicitly set. Instead, uses getBoundingClientRect() to determine the rendered width of the div.
- Adds automatic axis label wrapping using Mike's function from http://bl.ocks.org/mbostock/7555321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.