fix: Avoid restoring platform input control#7
Closed
EArminjon wants to merge 1 commit intoMasum-MSNR:mainfrom
Closed
fix: Avoid restoring platform input control#7EArminjon wants to merge 1 commit intoMasum-MSNR:mainfrom
EArminjon wants to merge 1 commit intoMasum-MSNR:mainfrom
Conversation
EArminjon
force-pushed
the
fix/avoid-restoring-platform-input-control
branch
from
46d363e to
36e6556
Compare
EArminjon
force-pushed
the
fix/avoid-restoring-platform-input-control
branch
from
36e6556 to
8cc3ae7
Compare
EArminjon
commented
Mar 13, 2026
Owner
|
Thanks for the PR and the detailed explanation! I’ll review it and merge shortly. Appreciate your continued contributions. |
Masum-MSNR
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario :
Behavior :
The virtual keypad no longer work and open.
Explanation :
The first page
disposeis called after the second pageinitState. In Flutter, thedisposecallback is called at the moment at the page disappear from the screen, so at the end of thepopanimation. Callingpopdidn't call directlydispose.By consequence, the second page which call
TextInput.setInputControl(...)in hisinitStateis override by theTextInput.restorePlatformInputControl()present in the previous pagedispose.This PR remove the useless
TextInput.restorePlatformInputControl(). We didn't see any issue on our app using that.