Default AutomationProperties.Name to HintAssist.Hint #3913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so it can be picked up by a screen reader
…fault so it can be picked up by a screen reader
Keboo
approved these changes
Sep 5, 2025
Keboo
added
enhancement
release notes
|
I agree. We can't handle complex headers as there are too many edge cases to try and figure out. As nice as it would be, I think leaving those in the hands of the application author is best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3904
This PR sets the default value of the
AutomationProperties.Nameto theHintAssist.Hintof the respective input control, so that a screen reader picks up the hint-text by default.The effected controls are essentially all the input controls:
TextBoxPasswordBoxComboBoxDatePickerTimePickerNumericUpDownAutoSuggestBoxI successfully tested the changes with the NVDA screen reader.
The issuer is talking about supporting "complex headers" too, but do we really want to support something like this?
In my opinion, we shouldn't, see my comment.