Enforce non-zero replica scale and workers #34260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
replica-size-nonzero
branch
3 times, most recently
from
64fbdf5 to
c2b7a5f
Compare
This commit changes `ReplicaAllocation` to enforce non-zero values for `scale` and `workers`. This makes Materialize refuse to start with replica sizes that specify zero for these values. Previously Materialize would start up but would panic as soon as one tried to create a replica with such an invalid size.
teskje
force-pushed
the
replica-size-nonzero
branch
from
c2b7a5f to
e0cd299
Compare
teskje
requested review from
SangJunBak and
aljoscha
and removed request for
aljoscha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
ReplicaAllocationto enforce non-zero values forscaleandworkers. This makes Materialize refuse to start with replica sizes that specify zero for these values. Previously Materialize would start up but would panic as soon as one tried to create a replica with such an invalid size.Motivation
Self-managed users can get their environment into a weird state by specifying replica sizes with 0 processes, causing, e.g., division-by-zero errors in the console, and panics when trying to create clusters with such sizes.
Relevant Slack thread.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.