Skip to content

timely-util: specialize reclock compaction to total orders #34267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

timely-util: specialize reclock compaction to total orders #34267

wants to merge 1 commit into from

Conversation

@petrosagg
Copy link
Contributor

@petrosagg petrosagg commented Nov 24, 2025

Since the reclock operator stores the reclock bindings in time order and we restrict IntoTime to be a total order we can perform compaction in a much cheaper way and only when necessary.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@petrosagg
timely-util: specialize reclock compaction to total orders
1ae5973 
Since the reclock operator stores the reclock bindings in time order and
we restrict `IntoTime` to be a total order we can perform compaction in
a much cheaper way and only when necessary.

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg marked this pull request as ready for review November 24, 2025 20:51
@petrosagg petrosagg requested a review from a team as a code owner November 24, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@petrosagg