Skip to content

Fixed some translation strings for Korean #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aerialcombat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed some translation strings for Korean #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DateToolsSwift/DateTools/DateTools.bundle/ko.lproj/DateTools.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@
"An hour ago" = "1시간 전";

/* No comment provided by engineer. */
"Just now" = "방금 전";
Copy link
Author

@aerialcombat aerialcombat Dec 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be discrepancy in whether 방금 is more commonly used or 방금 전 is more commonly used. 전 means
ago. 방금(A short time ago) already has the meaning 'ago', but according to the National Korean Language Institute, there has been use cases of 방금 전 being used in real life.
http://www.korean.go.kr/front/mcfaq/mcfaqView.do?mn_id=62&mcfaq_seq=2561

This could be more of a preference choice, so... Do what you will

"Just now" = "방금";

/* No comment provided by engineer. */
"Last month" = "지난 달";
"Last month" = "지난달";

/* No comment provided by engineer. */
"Last week" = "지난 주";
"Last week" = "지난주";

/* No comment provided by engineer. */
"Last year" = "지난 해";
"Last year" = "작년";

/* No comment provided by engineer. */
"Yesterday" = "어제";
Expand Down