Skip to content

Conversation

@maniramezan
Copy link

Fix the issue with SwiftPM setup and add auto generated files to .gitignore

@bryan1anderson
Copy link

@maniramezan This fails at return Bundle(path: NSString(string: assetPath).appendingPathComponent("DateTools.bundle"))!
Force unwrap a nil optional. Are bundles allowed in SwiftPM at the moment? I didn't think resource files were allowed

@maniramezan
Copy link
Author

@bryan1anderson Yeah, so far it's not possible to add bundles to SwiftPM, package manager resources seems to be a proposal for it. For now, it requires to add them manually.

@MatthewYork
Copy link
Owner

Alright, I have returned. Quit my job, started a business, and had a child....

But definitely ready to merge in SwiftPM support! Please see the recent Swift 5 release and re-evaluate the pull request just to make sure none of my changes bothered yours.

Really appreciate it!

@MatthewYork
Copy link
Owner

I'm going to close this request. Please reopen branching off the new release and I will merge. Thanks!

@maniramezan maniramezan deleted the swiftpm_support branch February 10, 2020 00:06
@maniramezan
Copy link
Author

@MatthewYork Congrats! 🍾🎉

I opened a PR regarding adding SwiftPM #291 based on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants