Hide buttons when logged out#849
Open
notama-nr2527 wants to merge 2 commits intoMauroDataMapper:mainfrom
Open
Conversation
added 2 commits
March 8, 2024 12:02
…ons; hide "Add Terms" & "Add Relationship Type" buttons, as well as the icons for rule editing. The buttons already do nothing since the object they changed is not accesssible when logged out. Thus, we prevent a spurious error message to be shown.
Before, we were blindly following the loggedIn status; now we also follow backend's hints/permissions of whether we should show the button, in addition to checking if the user is logged in.
|
Pedro Francisco seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loggd out: Hide "Add Data Class" and "Add Rule" & "Export" buttons;
hide "Add Terms" & "Add Relationship Type" buttons, as well as the icons
for rule editing.
The buttons already do nothing since the object they changed is not
accesssible when logged out. Thus, we prevent a spurious error message
to be shown.
Apply Welch's suggestions: add canEdit boolean and fill it apropriately.
Before, we were blindly following the loggedIn status; now we also follow
backend's hints/permissions of whether we should show the button, in
addition to checking if the user is logged in.