Add comprehensive Playwright E2E tests for database verification workflow by Copilot · Pull Request #78 · MaximumTrainer/OpenDataMask

Copilot · 2026-04-17T17:08:06Z

…flow Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

…back Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

…gitignore Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot

Pull request overview

Adds a Playwright E2E test suite to exercise the database verification workflow against the existing verification sandbox environment.

Changes:

Add Playwright configuration and dev dependency for running E2E tests.
Introduce shared E2E fixtures/utilities plus multiple UI/API-driven workflow specs.
Adjust Vitest config to avoid collecting e2e/** tests and ignore Playwright output in git.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
frontend/vite.config.ts	Updates Vitest config to exclude E2E tests (but currently replaces default excludes).
frontend/playwright.config.ts	Adds Playwright runner configuration targeting the verification sandbox URL.
frontend/package.json	Adds `@playwright/test` as a dev dependency.
frontend/package-lock.json	Locks Playwright-related dependency tree.
frontend/e2e/odm-fixtures.ts	Adds shared E2E fixtures + API helpers + seeding utilities.
frontend/e2e/auth.spec.ts	Adds authentication-focused E2E coverage.
frontend/e2e/connections.spec.ts	Adds connection CRUD/validation E2E coverage.
frontend/e2e/masking-definition.spec.ts	Adds masking definition + mapping wizard E2E coverage.
frontend/e2e/job-execution.spec.ts	Adds job execution + transfer verification E2E coverage.
frontend/e2e/full-workflow.spec.ts	Adds a serial full “verification script” workflow E2E spec.
frontend/.gitignore	Ignores Playwright output directories.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-17T17:13:55Z

+import {
+  ODM_USERNAME,
+  ODM_PASSWORD,
+  ODM_EMAIL,


ODM_EMAIL is imported but never used in this spec. This will fail the repo’s eslint script (no-unused-vars) and should be removed (or used if intended).

Suggested change

ODM_EMAIL,

Copilot · 2026-04-17T17:13:55Z

+  test('test connection button triggers connection test', async ({ authenticatedPage: page }) => {
+    // Seed a connection via API
+    let connId: number
+    try {
+      const conn = await apiCall(`/api/workspaces/${workspaceId}/connections`, {
+        method: 'POST',
+        body: {
+          name: 'test-btn-conn',
+          type: 'POSTGRESQL',
+          connectionString: `jdbc:postgresql://${SOURCE_DB.host}:${SOURCE_DB.port}/${SOURCE_DB.database}`,
+          username: SOURCE_DB.username,
+          password: SOURCE_DB.password,
+          isSource: true,
+          isDestination: false,
+        },
+        token,
+      })
+      connId = conn.id as number
+    } catch {


let connId: number is assigned in the try block but never used. This will be flagged by ESLint and should be removed (or asserted against to ensure the seeded connection is the one being tested).

Copilot · 2026-04-17T17:13:56Z

+  test('edit connection modal pre-fills existing data', async ({ authenticatedPage: page }) => {
+    // Seed a connection via API
+    const conn = await apiCall(`/api/workspaces/${workspaceId}/connections`, {
+      method: 'POST',
+      body: {
+        name: 'edit-test-conn',
+        type: 'POSTGRESQL',
+        connectionString: `jdbc:postgresql://${SOURCE_DB.host}:${SOURCE_DB.port}/${SOURCE_DB.database}`,
+        username: SOURCE_DB.username,
+        password: SOURCE_DB.password,
+        isSource: true,
+        isDestination: false,
+      },
+      token,
+    })


The conn variable returned from apiCall(...) is never used in this test. Keeping the assignment triggers ESLint’s unused-vars rule; remove the variable (just await apiCall(...)) or use it in an assertion.

Copilot · 2026-04-17T17:13:56Z

+import {
+  ODM_USERNAME,
+  ODM_PASSWORD,
+  ODM_EMAIL,
+  SOURCE_DB,
+  TARGET_DB,
+  registerUser,
+  loginViaApi,
+  apiCall,
+  waitForPageHeading,
+  waitForLoadingDone,
+  waitForJobCompletion,
+  type IdResponse,
+  type WorkspaceResponse,
+  type ConnectionResponse,
+  type JobResponse,
+  type JobLogEntry,
+  type ConnectionTestResponse,
+} from './odm-fixtures'


ODM_EMAIL is imported but never used in this spec. Since frontend runs eslint . ..., this will fail the lint step; remove the unused import.

Copilot · 2026-04-17T17:13:56Z

+export async function registerUser(): Promise<void> {
+  try {
+    await apiCall('/api/auth/register', {
+      method: 'POST',
+      body: { username: ODM_USERNAME, email: ODM_EMAIL, password: ODM_PASSWORD },
+    })
+  } catch {
+    // User may already exist — safe to ignore.


registerUser currently swallows all failures from the register endpoint (including network errors / 5xx), which can make later test failures hard to diagnose. Consider only ignoring the expected “already exists” case (e.g. based on status/message), and rethrow unexpected errors.

Suggested change

export async function registerUser(): Promise<void> {

try {

await apiCall('/api/auth/register', {

method: 'POST',

body: { username: ODM_USERNAME, email: ODM_EMAIL, password: ODM_PASSWORD },

})

} catch {

// User may already exist — safe to ignore.

function isAlreadyRegisteredError(error: unknown): boolean {

if (!(error instanceof Error)) return false

const message = error.message.toLowerCase()

return (

message.includes('→ 409:') ||

message.includes('already exists') ||

message.includes('already registered')

)

}

export async function registerUser(): Promise<void> {

try {

await apiCall('/api/auth/register', {

method: 'POST',

body: { username: ODM_USERNAME, email: ODM_EMAIL, password: ODM_PASSWORD },

})

} catch (error) {

if (!isAlreadyRegisteredError(error)) {

throw error

}

Copilot · 2026-04-17T17:13:56Z

+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export async function apiCall<T = Record<string, any>>(
+  path: string,
+  { method = 'GET', body, token }: ApiOptions = {}
+): Promise<T> {
+  const headers: Record<string, string> = { 'Content-Type': 'application/json' }
+  if (token) headers['Authorization'] = `Bearer ${token}`
+
+  const res = await fetch(`${API_BASE}${path}`, {
+    method,
+    headers,
+    body: body ? JSON.stringify(body) : undefined,
+  })
+
+  if (!res.ok) {
+    const text = await res.text().catch(() => '')
+    throw new Error(`API ${method} ${path} → ${res.status}: ${text}`)
+  }
+
+  const text = await res.text()
+  return text ? JSON.parse(text) : ({} as T)
+}


apiCall defaults T to Record<string, any> and returns ({} as T) for empty responses. This makes it easy for call sites to fall back to any + as number casts (which already happens in the specs) and conflicts with the PR description’s “no unsafe casts” goal. Consider requiring an explicit generic (default to unknown), and returning undefined/null for empty bodies so types stay honest.

Copilot · 2026-04-17T17:13:57Z

  test: {
-    environment: 'node'
+    environment: 'node',
+    exclude: ['e2e/**', 'node_modules/**']
  }


test.exclude here overrides Vitest’s default exclude globs. With only ['e2e/**','node_modules/**'], other default excludes (e.g. dist/output/temp and config files) are no longer excluded, which can make Vitest pick up unintended test files or slow down collection. Consider extending configDefaults.exclude (from vitest/config) and appending e2e/** instead of replacing the list.

Copilot · 2026-04-17T17:13:57Z

+  test('expand table to view column generators section', async ({ authenticatedPage: page }) => {
+    // Seed a table config via API
+    const tbl = await apiCall(`/api/workspaces/${workspaceId}/tables`, {
+      method: 'POST',
+      body: {
+        connectionId: sourceConnectionId,
+        tableName: 'users_expand_test',
+        schemaName: 'public',
+        mode: 'MASK',
+      },
+      token,
+    })


const tbl = await apiCall(...) is declared but never used in this test, which will fail linting. Either remove the variable or use it to target the specific seeded table row (instead of always expanding the first table).

Copilot · 2026-04-17T17:13:57Z

+  waitForLoadingDone,
+  type JobResponse,
+  type JobLogEntry,
+  type ConnectionTestResponse,


ConnectionTestResponse is imported but never used in this file. This will be reported by ESLint; remove the unused type import.

Suggested change

type ConnectionTestResponse,

MaximumTrainer · 2026-04-17T17:30:49Z

@copilot apply changes based on the comments in this thread

…, extend vitest exclude defaults Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/e32c6a4c-f45b-4dd1-adc8-c6f4b5e2b288 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot · 2026-04-17T17:33:24Z

@copilot apply changes based on the comments in this thread

Applied all 9 review comments in commit 2b5197e:

Removed unused ODM_EMAIL imports from auth.spec.ts and full-workflow.spec.ts
Removed unused ConnectionTestResponse import from job-execution.spec.ts
Removed unused connId and conn variables in connections.spec.ts
Removed unused tbl variable in masking-definition.spec.ts
Changed apiCall default generic from Record<string, any> to unknown
Improved registerUser() to only ignore 409/already-exists errors, rethrowing unexpected failures
Extended configDefaults.exclude from vitest/config instead of replacing the defaults

Copilot AI and others added 3 commits April 17, 2026 16:56

Add comprehensive Playwright e2e tests for database verification work…

a029cea

…flow Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Improve type safety in Playwright e2e tests based on code review feed…

f48ff10

…back Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Remove playwright-report from git and add Playwright output dirs to .…

698d064

…gitignore Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/c0576442-108f-4e13-b8ac-78825dc03ec3 Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com>

Copilot AI assigned Copilot and MaximumTrainer Apr 17, 2026

Copilot created this pull request from a session on behalf of MaximumTrainer April 17, 2026 17:08 View session

MaximumTrainer requested a review from Copilot April 17, 2026 17:08

Copilot started reviewing on behalf of MaximumTrainer April 17, 2026 17:09 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Copilot started work on behalf of MaximumTrainer April 17, 2026 17:30 View session

Copilot finished work on behalf of MaximumTrainer April 17, 2026 17:34

Copilot AI requested a review from MaximumTrainer April 17, 2026 17:34

MaximumTrainer marked this pull request as ready for review April 17, 2026 17:43

MaximumTrainer approved these changes Apr 17, 2026

View reviewed changes

MaximumTrainer merged commit 7aa427f into main Apr 17, 2026
10 checks passed

MaximumTrainer deleted the copilot/add-playwright-tests-for-database-verification branch April 18, 2026 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add comprehensive Playwright E2E tests for database verification workflow#78

Add comprehensive Playwright E2E tests for database verification workflow#78
MaximumTrainer merged 4 commits intomainfrom
copilot/add-playwright-tests-for-database-verification

Copilot AI commented Apr 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

MaximumTrainer commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

MaximumTrainer commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 17, 2026 •

edited

Loading