Update Attribute Component #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way attribute modifiers are handled and loaded in the codebase, introducing a new
AttributeWrapperabstraction and supporting an attribute merge strategy for greater flexibility. The changes also update the component loader to use the new structure and ensure proper plugin context is passed throughout. Additionally, there are minor tweaks to packet event handling logic.Attribute Modifiers Refactor and Loader Enhancements:
AttributeModifiersComponentto useAttributeWrapperobjects and anAttributeMergeStrategy, replacing the previous tuple-based approach. The component now relies on anAttributApplierfor applying attributes and requires aMenuPlugininstance.SpigotAttributeModifiersItemComponentLoaderto accept aMenuPluginin its constructor, parse an optionalattribute-merge-strategyfrom the configuration, and constructAttributeWrapperinstances for each modifier. The loader now passes these to the updatedAttributeModifiersComponent. [1] [2] [3] [4]SpigotAttributeModifiersItemComponentLoaderinZComponentsManagerto provide theMenuPlugininstance.SpigotPotionDurationScaleItemComponentLoaderinZComponentsManager.Packet Event Handling:
PacketAnimationListenerto run tasks immediately if either the server is on the primary thread or the plugin is enabled (or not enabled, depending on the context), otherwise scheduling them for the next tick. [1] [2] [3]