Update send_video.py retains video coven when video is file id#155
Open
A-newstart wants to merge 1 commit intoMayuri-Chan:mainfrom
Open
Update send_video.py retains video coven when video is file id#155A-newstart wants to merge 1 commit intoMayuri-Chan:mainfrom
A-newstart wants to merge 1 commit intoMayuri-Chan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where passing a file_id for video together with a cover would not attach the cover to the sent media. Previously the code converted the cover to a helper/input object but did not attach it to the media returned by utils.get_input_media_from_file_id(video, FileType.VIDEO, ...). As a result, videos sent via file_id lost their video_cover.
Root cause
When video was a local file or URL we constructed raw.types.InputMediaUploadedDocument / InputMediaDocumentExternal and set video_cover correctly.
When video was a file_id, we used utils.get_input_media_from_file_id(...) to build media but never assigned media.video_cover = vidcover_file.
note: used ai to solve this dont know if its correct or not but worked and hope problem got detected.