Skip to content

assemble_changelog.py: Clean up datetime.fromtimestamp timezone handling #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

assemble_changelog.py: Clean up datetime.fromtimestamp timezone handling #174

wants to merge 1 commit into from

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Jun 11, 2025 •
edited
Loading

Get rid of harmless warnings when you run assemble_changelog.py with Python ≥3.12. We're using a deprecated function datetime.datetime.utcfromtimestamp, but we happen to be using it safely, and at the time of posting the function hasn't been removed yet.

This is the only script where we use datetime.datetime.utcfromtimestamp.

PR checklist

  • TF-PSA-Crypto PR not required because: only refactoring
  • development PR not required because: only refactoring
  • 3.6 PR not required because: only refactoring

@gilles-peskine-arm
Clean up datetime.fromtimestamp timezone handling
caba423 
Replace `datetime.datetime.utcfromtimestamp`, which is deprecated since
Python 3.12, by `datetime.datetime.fromtimestamp` on
`datetime.timezone.utc`, which has existed since Python 3.2.

Also fix file timestamps, which were in the local time zone rather than UTC.
This had no practical consequence since the script only uses those
timestamps to compare with other file timestamps. (In particular, all
uncommitted files are ordered after all committed files, so the script never
compares a formerly-UTC timestamp of a committed file to a formerly-local
timestamp of an uncommitted file.)

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jun 11, 2025
@gilles-peskine-arm gilles-peskine-arm changed the title Clean up datetime.fromtimestamp timezone handling assemble_changelog.py: Clean up datetime.fromtimestamp timezone handling Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gilles-peskine-arm