Skip to content

Exclude "WIN32_LEAN_AND_MEAN" from name check #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exclude "WIN32_LEAN_AND_MEAN" from name check #193

wants to merge 1 commit into from

Conversation

irwir
Copy link

@irwir irwir commented Jul 30, 2025

Description

Macro WIN32_LEAN_AND_MEAN excludes a few APIs that are rarely used. If needed, the necessary headers would be added explicitly.
The macro goes into a header file and thus should be in the exceptions of the name check script (to be used in Mbed-TLS/TF-PSA-Crypto#262 or a follow-up).

PR checklist

  • TF-PSA-Crypto PR not required
  • development PR not required
  • 3.6 PR not required because no backport was planned.

@irwir
Exclude "WIN32_LEAN_AND_MEAN" from name check.
45fce26 
Signed-off-by: irwir <irwir@users.noreply.github.com>
gilles-peskine-arm
gilles-peskine-arm approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jul 30, 2025
@irwir irwir mentioned this pull request Aug 15, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irwir @gilles-peskine-arm