Minor all.sh improvements for 3.6 #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
The `--root` option was mostly ineffective since you could only use if the current directory was some other mbedtls or TF-PSA-Crypto root. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Just call `make generated_files`. `--list` won't work yet, because 3.6 currently lacks a way to list the generated files. We'll need to add support for `make list_generated_files`. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
enhancement
github-project-automation
bot
moved this to In Development
in Non-roadmap pull requests
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to
all.shandmake_generated_files.py, mostly relevant for 3.6:make_generated_files.pywork in 3.6 as well. It's trivial and more convenient. Needs 3.6 only: make list_generated_files mbedtls#10339 formake_generated_files.py --listin 3.6.make list_generated_filesto work even when called fromall.shwith the make ”quiet wrapper“ active.make_generated_files.py --root DIRnot working.all.shcleanup, do remove$OUT_OF_SOURCE_DIRin mbedtls too (3.6 and development). We use it so we should clean it.PR checklist