Fix generate_config_checks.py not actually generating the files #211
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`output_files` was accidentally an iterator that was not iterated over unless one of the list-only options was enabled. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-review
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
| output_files = generate_header_files(branch_data, | ||
| options.output_directory, | ||
| list_only=list_only) | ||
| output_files = list(generate_header_files(branch_data, |
There was a problem hiding this comment.
The fact that we all missed this at first shows that this is not a good way to write the code. But right now I'd rather unblock the chain of PR ASAP.
mpg
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
LGTM.
I feel silly for missing this, because I was about to say the function might as well return a list (or tuple) directly, then I thought it's probably a matter of taste, let's not delay the PR over this... but completely missed the practical impact here :(
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
gilles-peskine-arm
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
This was referenced Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix silly mistake in #196 that clogs up the chain of consumers.
PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.