Fix make_generated_files --check #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-preceding-pr
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
gilles-peskine-arm
force-pushed
the
make_generated_files-fix-check
branch
from
d11a4cb to
043ef98
Compare
ronald-cron-arm
approved these changes
Dec 4, 2025
Contributor
ronald-cron-arm
left a comment
ronald-cron-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
Contributor
|
It seems the PR needs to be rebased though. |
mypy only checks types in functions that have a return type annotation. In `check_generated_files`, change from returning `None` to returning a boolean, since the function is supposed to check some boolean-valued assertion. So far, the function always returns `True`. In `main`, explicitly return an `int` value as expected by the caller. When calling `check_generated_files`, convert the boolean result into an exit status. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Return a nonzero status if called with `--check` and the check finds some problems. Fixes Mbed-TLS#244. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
make_generated_files-fix-check
branch
from
043ef98 to
ededeaa
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #244
Needs preceding PR: Mbed-TLS/mbedtls#10530 to fix a problem that this was reporting, but only as some lines in the log, not with a failure status. Note that the CI passes regardless, because on the CI in
mbedtls-framework, we set both copies of the framework to the head of the pull request, and this PR only causes a CI failure at the moment becausembedtls/tf-psa-crypto/frameworkis outdated compared tombedtls/framework. If we merge this PR before the mbedtls PR, it may cause breakage if we then update the framework in TF-PSA-Crypto but not in Mbed TLS.PR checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: