-
Notifications
You must be signed in to change notification settings - Fork 29
Add Ubuntu 24.04 Dockerfile #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gilles-peskine-arm
wants to merge
8
commits into
main
Choose a base branch
from
dev/gilles-peskine-arm/ubuntu-24.04-dockerfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Ubuntu 24.04 Dockerfile #230
gilles-peskine-arm
wants to merge
8
commits into
main
from
dev/gilles-peskine-arm/ubuntu-24.04-dockerfile
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker build` truncates our long image name when it has fancy formatted output. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This makes the output suitable for `build.sh`, which expects a single image name for a given prefix. Fixes #204 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This changes the order, but in a way that shouldn't matter: we still have amd64 prioritized over arm64, and Ubuntu versions in the same order. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
No `all.sh` component is currently using 20.04. Currently, the default is 16.04, some components have requirements that cause 18.04 to be used, and a few components have requirements that cause 22.04 to be used. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Moved the ubuntu-22.04 Dockerfile with the version number changed. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Register `ubuntu-24.04` Docker image instead of `ubuntu-22.04`. The jobs that were running on Ubuntu 22.04 due to tool dependencies will now run on Ubuntu 24.04. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
For `gcc-latest`, move to GCC 14 which is the latest in this version of Ubuntu. Don't move to GCC 15 even though we're already using it because setting `gcc-latest` to GCC 15 still breaks our CI: Mbed-TLS/TF-PSA-Crypto#584 For `clang-latest`, use the latest non-beta version of Clang at this time. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
The system pip and setuptools are fine. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
372de9e to
e49c3dd
Compare
Contributor
Author
|
This is ready for review. CI jobs are still running but I've already had a pass with the same code and a different history. |
ronald-cron-arm
approved these changes
Dec 2, 2025
Contributor
ronald-cron-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on code inspection, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1/2 of #228: add Ubuntu 24.04 Dockerfile.
Also remove 20.04 which wasn't used, and replace 22.04 because we aren't doing anything that would benefit from 22.04 as opposed to 24.04.
Keep
arm-compilersat Ubuntu 20.04 because changing that triggers a license problem that I don't want to deal with.Move
clang-latestandgcc-latestforward while I'm at it:clang-latestto the current non-beta Clang, andgcc-latestto GCC 14 (not 15 because of Mbed-TLS/TF-PSA-Crypto#584).Test job: