Skip to content

Backport 3.6: Fix config.py --help when the current directory contains a percent character #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: mbedtls-3.6
Choose a base branch
from
Open

Backport 3.6: Fix config.py --help when the current directory contains a percent character #10135

wants to merge 3 commits into from
+4 −8

Conversation

gilles-peskine-arm
Copy link
Contributor

Branch-specific part of Mbed-TLS/mbedtls-framework#162. The two can be merged independently.

PR checklist

@gilles-peskine-arm
Fix config.py --help when $PWD contains %
be1b226 
Fix `config.py --help` raising an exception (or otherwise misbehaving, in
rare cases) when the current working directory contains a percent character.
This was due to a percent escape bug.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Simplify
618cd86 
The old code would have been wrong if a default value was changed to
contain a `%` character, since help strings are actually help formats with
percent escapes.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
Update framework
25282b4 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added bug component-platform Portability layer and build scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Apr 16, 2025
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug component-platform Portability layer and build scripts needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gilles-peskine-arm