Mechanism to error out on removed configuration options #10306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
bf54ded to
9995f03
Compare
7 tasks
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
9995f03 to
f745c31
Compare
5 tasks
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
f745c31 to
5a12986
Compare
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
5a12986 to
9cca937
Compare
3 tasks
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
9cca937 to
5582b64
Compare
gilles-peskine-arm
added
the
needs-review
|
This is ready for review. It isn't passing the CI yet, but fixing that should take just one more commit. |
gilles-peskine-arm
added
priority-very-high
|
I will rebase this once #10382 is merged. This should resolve the Windows-mingw build failure since that job will be removed from the CI. |
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
cb8a4b1 to
109cf72
Compare
|
I rebased a little too early (#10382 was still on the merge queue) so Windows-mingw is still failing. But anyway that job will go away, so the CI will pass once this is rebased again. This will need to be rebased again once the framework PR is merged, so I don't see any reason to rebase again right now. We'll have a green CI after the post-framework-merge rebase. |
mpg
reviewed
Sep 24, 2025
mpg
reviewed
Sep 24, 2025
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Read the list of historical config options in 3.6, compare that to 1.0/4.0 and emit the appropriate checkers. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Fix the build of libmbedx509 when generated files are not already present. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Indicate which config file has the most relevant tweak. Duplicate a few test cases so that both the crypto config and the mbedtls config are tested. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
config-error-on-removed-options-mbedtls
branch
from
0dafd09 to
3cee43e
Compare
gilles-peskine-arm
removed
the
needs-preceding-pr
|
Rebased, hopefully for the last time, with the framework updated to the merge of Mbed-TLS/mbedtls-framework#164. The previous head is at https://github.com/gilles-peskine-arm/mbedtls/tree/config-error-on-removed-options-mbedtls-11 |
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
gilles-peskine-arm
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up a mechanism for erroring out if users try to use removed options in their configuration file. Resolves #10147.
Specification in Mbed-TLS/mbedtls-framework#184.
Status: ready.
Needed preceding PR: framework Mbed-TLS/mbedtls-framework#164
PR checklist