Conversation
|
I have rebased this branch on main (with previous commits), it seems that github doesn't care about PRs that depend on each other, maybe if you will merge previous, this PR will add only one commit |
|
I also suggest option in repo settings when PRs need approval only for new contributors |
|
Actually it is already set to |
|
Also, feel free to correct my wording — im not a native English speaker. I understand English better than I speak it, so I might make some mistakes here and there For the same reason, I would prefer not to write a documentation block for this feature if you decide to merge it :) |
|
And should we update custom-style.typ in funny-math example? Should custom styles respect multiple languages? |
|
Hi, I'm sorry that I'm only now getting back to your PR but I had some other important duties this week. I like the idea and would like to adopt this feature but I have one or two suggestions.
I will add a commit to address these points. |
This will also make it easier to adopt custom types later.
|
Later, with custom types, translations could be solved much easier and more natively I think but that's a story for a future time. |
|
Thank you! |
|
I just released an update with the new feature included. It should be on Typst Universe by the start of the next week :) |
Adds possibility to use
I used this file to determine all supported languages:
https://github.com/typst/typst/blob/main/crates/typst-library/src/text/lang.rs
Users can still use
local-namesargument to provide additional translations/customization (it will be prioritized), this PR is backwards compatibleThis one needs attention, maybe it could be done better than i did
Closes #47