Skip to content

Frontend: Use and maintain operators on the blockchain#10

Merged
MeKHell merged 14 commits intostudent25spring_access_controlfrom
operator-link-frontend-dela
May 20, 2025
Merged

Frontend: Use and maintain operators on the blockchain#10
MeKHell merged 14 commits intostudent25spring_access_controlfrom
operator-link-frontend-dela

Conversation

@MeKHell
Copy link
Owner

@MeKHell MeKHell commented Apr 30, 2025

The goal of this PR is to implement and adapt the management and authorization checks of the operators on the frontend. This links the role to the list on the blockchain…

This also adds some tests and fixes the ones that were broken by the new added code.

Note that this PR will also fix an undisclosed bug, where some empty forms were listed in the form list on the frontend.

This PR would solve the 3 last points of this issue: c4dt#199

In addition, this PR is also based on the changes waiting to be merged in #9. The first commit specific to this branch is 53c528e.

@MeKHell MeKHell self-assigned this Apr 30, 2025
@MeKHell MeKHell marked this pull request as ready for review April 30, 2025 15:44
@MeKHell MeKHell requested a review from PascalinDe April 30, 2025 15:45
@PascalinDe
Copy link
Collaborator

the commit 401abd0 is in https://github.com/MeKHell/d-voting/pull/9/commits, but missing here (the first 8 commits are the same)

is this a mistake?

@MeKHell
Copy link
Owner Author

MeKHell commented May 1, 2025

No,
Since both branch will be merged anyway on the same “mother branch” and this one wad created before I completed all the fixes on the other branch, there might be some changes in the other PR that are not here (fixes for your comments).

@PascalinDe
Copy link
Collaborator

since the other branch has now been merged, could you rebase this one on top of it before I review it? there might be merge conflicts that need to be integrated here, and it is easier for the reviewer/you if they are included as soon as possible to avoid another round of review for small changes :)

@MeKHell MeKHell force-pushed the operator-link-frontend-dela branch from 35e13cb to 9253a3b Compare May 5, 2025 08:32
@MeKHell MeKHell force-pushed the operator-link-frontend-dela branch from 9253a3b to a03d6e5 Compare May 5, 2025 08:34
@MeKHell MeKHell force-pushed the operator-link-frontend-dela branch from edda4ab to 3743c21 Compare May 17, 2025 17:24
@MeKHell MeKHell requested a review from PascalinDe May 19, 2025 08:45
Copy link
Collaborator

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeKHell MeKHell merged commit 06e874e into student25spring_access_control May 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants