Frontend: Use and maintain operators on the blockchain#10
Merged
MeKHell merged 14 commits intostudent25spring_access_controlfrom May 20, 2025
Merged
Frontend: Use and maintain operators on the blockchain#10MeKHell merged 14 commits intostudent25spring_access_controlfrom
MeKHell merged 14 commits intostudent25spring_access_controlfrom
Conversation
Collaborator
|
the commit 401abd0 is in https://github.com/MeKHell/d-voting/pull/9/commits, but missing here (the first 8 commits are the same) is this a mistake? |
Owner
Author
|
No, |
Collaborator
|
since the other branch has now been merged, could you rebase this one on top of it before I review it? there might be merge conflicts that need to be integrated here, and it is easier for the reviewer/you if they are included as soon as possible to avoid another round of review for small changes :) |
35e13cb to
9253a3b
Compare
added 13 commits
May 5, 2025 10:34
9253a3b to
a03d6e5
Compare
PascalinDe
reviewed
May 5, 2025
edda4ab to
3743c21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to implement and adapt the management and authorization checks of the operators on the frontend. This links the role to the list on the blockchain…
This also adds some tests and fixes the ones that were broken by the new added code.
Note that this PR will also fix an undisclosed bug, where some empty forms were listed in the form list on the frontend.
This PR would solve the 3 last points of this issue: c4dt#199
In addition, this PR is also based on the changes waiting to be merged in #9. The first commit specific to this branch is 53c528e.