Skip to content

Fix voters unable to cast#11

Merged
MeKHell merged 3 commits intostudent25spring_access_controlfrom
fix-voters-unable-to-cast
May 20, 2025
Merged

Fix voters unable to cast#11
MeKHell merged 3 commits intostudent25spring_access_controlfrom
fix-voters-unable-to-cast

Conversation

@MeKHell
Copy link
Owner

@MeKHell MeKHell commented May 19, 2025

The main goal of this PR is to fix the bug c4dt#200 where users could not vote anymore after the previous changes.

In addition, it will:

  • Fix the shuffling process which was also broken but hidden behind the non-working voting process
  • Fix a small issue with 2 times the same conditional statement into one another
  • Fix a wrong error message
  • Fix a title in the 3 languages which was very confusing for the user

@MeKHell MeKHell self-assigned this May 19, 2025
@MeKHell MeKHell requested a review from PascalinDe May 19, 2025 09:32
@MeKHell MeKHell marked this pull request as ready for review May 19, 2025 09:33
Copy link
Collaborator

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeKHell MeKHell merged commit 0300d8c into student25spring_access_control May 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants