Add Observable pattern to Network Inputs #182
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR draft extends the LoggedNetworkInputs ABC with an Observable pattern:
This is a modification of an extension that my team is using this season (via a wrapper class):
Due to some limitations of my understanding of AKit, I don't know if the notifying of listeners only should happen in the NOT replay source case (see periodic of concrete classes) or in all cases.
I'm also not certain if extending the LoggedNetworkInputs ABC is ideal, I originally modified LoggedNetworkInputs, but was confused while conforming LoggedDashboardChooser so went this route instead.
I thought I'd offer this to AKit because I'm sure other teams may find this useful. Let me know if you have/request any changes or want some explanation of reasonings.