Skip to content

Conversation

@danielgomezrico
Copy link
Contributor

@danielgomezrico danielgomezrico commented Feb 21, 2021

Separate code with a repository

Copy link
Collaborator

@cdmunoz cdmunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Giving specific responsibilities will help us to maintain easier the base code 🚀

}

override fun onFailure(call: Call<User>, t: Throwable) {
responseCallback(null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we gonna manage an error! are we going to log it? how do we internally know that an error happened?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:O thanks, I didn't notice I missed it!

@danielgomezrico danielgomezrico marked this pull request as draft January 10, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants