Skip to content

Conversation

@eugenesvk
Copy link
Contributor

This fixes #1267

@eugenesvk
Copy link
Contributor Author

eugenesvk commented May 25, 2020

I see that this Travis CI job failed with ../.libs/libmediainfo.so: undefined reference to 'MediaInfoLib::Encoded_Library_Tag' error and with these options seemingly different from a successfull build

-DMEDIAINFO_ALL_NO -DMEDIAINFO_MIXML_YES"
$ export RUN_TESTS="mixml"

Not sure what these are and how I can turn them on on my side to test (I was only using the MSVC2019 project), so will wait for your input

@JeromeMartinez
Copy link
Member

@eugenesvk thanks for the PR. I don't want to have more source file for this unique item, I'll adapt your patch proposal.

@eugenesvk
Copy link
Contributor Author

That's totally fine, it was just the simplest way I found to fix it (I was also thinking of disabling the split into name/version as at first glance it only seemed to be useful to remove a "-" in "x265 - ..." :), but then it was more complicated to trying to figure out all of its uses

@eugenesvk
Copy link
Contributor Author

Any chance you can add it as is so that it's usable and then adapt it later when you have time not to wait 5 more years with a bug?

@JeromeMartinez
Copy link
Member

not to wait 5 more years with a bug

We owe you this one, definitely not right that we have let it open (it felt in the too long todo-list), you don't deserve that.
We'll manage that this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retain the Encoded Library information stored in a tag

2 participants